Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rootless + smaller image + cleanup #402

Open
wants to merge 15 commits into
base: v1.10.0
Choose a base branch
from

Conversation

chevdor
Copy link

@chevdor chevdor commented Nov 19, 2024

This PR looks bigger than it is, due to the removal of leading spaces...

Here are the changes:

  • all the doc moves to it own subfolder
  • the scripts also gets a cosier home
  • container files (like Dockerfile) move to a new container subfolder
  • the container image (even though it was not the goal) shrinks from 582MB to 405MB
  • the container is now rootless 🎉
  • addition of a justfile, it is convenient for those using it, inert for others. It provides also a nice doc and shows how to build the images. See below.

justfile

Users not using just can just ignore.
For others, you need to set your IMAGE=... in the .env file. It will typically look like IMAGE=your_name/lndg.
Alternatively, you may provide your own registry: IMAGE=docker.io/chevdor/lndg.
After that, you may just 😄 run: just build_image and just push_image.

WARNING: Change for Docker users lndg is now in /lndg/ and no longer /app.

@chevdor chevdor marked this pull request as ready for review November 19, 2024 10:44
@chevdor chevdor marked this pull request as draft November 19, 2024 10:55
@chevdor chevdor marked this pull request as ready for review November 19, 2024 11:12
@cryptosharks131 cryptosharks131 changed the base branch from master to v1.10.0 November 24, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants